| 1 | //////////////////////////////////////////////////////////////////////////////// | |
| 2 | // checkstyle: Checks Java source code for adherence to a set of rules. | |
| 3 | // Copyright (C) 2001-2018 the original author or authors. | |
| 4 | // | |
| 5 | // This library is free software; you can redistribute it and/or | |
| 6 | // modify it under the terms of the GNU Lesser General Public | |
| 7 | // License as published by the Free Software Foundation; either | |
| 8 | // version 2.1 of the License, or (at your option) any later version. | |
| 9 | // | |
| 10 | // This library is distributed in the hope that it will be useful, | |
| 11 | // but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 12 | // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
| 13 | // Lesser General Public License for more details. | |
| 14 | // | |
| 15 | // You should have received a copy of the GNU Lesser General Public | |
| 16 | // License along with this library; if not, write to the Free Software | |
| 17 | // Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | |
| 18 | //////////////////////////////////////////////////////////////////////////////// | |
| 19 | ||
| 20 | package com.puppycrawl.tools.checkstyle.checks.coding; | |
| 21 | ||
| 22 | import antlr.collections.AST; | |
| 23 | import com.puppycrawl.tools.checkstyle.StatelessCheck; | |
| 24 | import com.puppycrawl.tools.checkstyle.api.AbstractCheck; | |
| 25 | import com.puppycrawl.tools.checkstyle.api.DetailAST; | |
| 26 | import com.puppycrawl.tools.checkstyle.api.TokenTypes; | |
| 27 | ||
| 28 | /** | |
| 29 | * <p>Checks that string literals are not used with | |
| 30 | * {@code ==} or <code>!=</code>. | |
| 31 | * </p> | |
| 32 | * <p> | |
| 33 | * Rationale: Novice Java programmers often use code like | |
| 34 | * {@code if (x == "something")} when they mean | |
| 35 | * {@code if ("something".equals(x))}. | |
| 36 | * </p> | |
| 37 | * | |
| 38 | * @author Lars Kühne | |
| 39 | * @noinspection HtmlTagCanBeJavadocTag | |
| 40 | */ | |
| 41 | @StatelessCheck | |
| 42 | public class StringLiteralEqualityCheck extends AbstractCheck { | |
| 43 | ||
| 44 | /** | |
| 45 | * A key is pointing to the warning message text in "messages.properties" | |
| 46 | * file. | |
| 47 | */ | |
| 48 | public static final String MSG_KEY = "string.literal.equality"; | |
| 49 | ||
| 50 | @Override | |
| 51 | public int[] getDefaultTokens() { | |
| 52 |
1
1. getDefaultTokens : mutated return of Object value for com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheck::getDefaultTokens to ( if (x != null) null else throw new RuntimeException ) → KILLED |
return getRequiredTokens(); |
| 53 | } | |
| 54 | ||
| 55 | @Override | |
| 56 | public int[] getAcceptableTokens() { | |
| 57 |
1
1. getAcceptableTokens : mutated return of Object value for com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheck::getAcceptableTokens to ( if (x != null) null else throw new RuntimeException ) → KILLED |
return getRequiredTokens(); |
| 58 | } | |
| 59 | ||
| 60 | @Override | |
| 61 | public int[] getRequiredTokens() { | |
| 62 |
1
1. getRequiredTokens : mutated return of Object value for com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheck::getRequiredTokens to ( if (x != null) null else throw new RuntimeException ) → KILLED |
return new int[] {TokenTypes.EQUAL, TokenTypes.NOT_EQUAL}; |
| 63 | } | |
| 64 | ||
| 65 | @Override | |
| 66 | public void visitToken(DetailAST ast) { | |
| 67 | // no need to check for nulls here, == and != always have two children | |
| 68 | final AST firstChild = ast.getFirstChild(); | |
| 69 | final AST secondChild = firstChild.getNextSibling(); | |
| 70 | ||
| 71 |
1
1. visitToken : negated conditional → KILLED |
if (firstChild.getType() == TokenTypes.STRING_LITERAL |
| 72 |
1
1. visitToken : negated conditional → KILLED |
|| secondChild.getType() == TokenTypes.STRING_LITERAL) { |
| 73 |
1
1. visitToken : removed call to com/puppycrawl/tools/checkstyle/checks/coding/StringLiteralEqualityCheck::log → KILLED |
log(ast.getLineNo(), ast.getColumnNo(), |
| 74 | MSG_KEY, ast.getText()); | |
| 75 | } | |
| 76 | } | |
| 77 | ||
| 78 | } | |
Mutations | ||
| 52 |
1.1 |
|
| 57 |
1.1 |
|
| 62 |
1.1 |
|
| 71 |
1.1 |
|
| 72 |
1.1 |
|
| 73 |
1.1 |